It fails on test top level domains
annard opened this issue · comments
Given the list of domains noted in this wikipedia article domainatrex fails during our tests on "x.test" or "x.invalid" or x.example". These may not be used in the wider internet but they are valid domain names.
The problem is that these names are not in the Public Suffix List. Reading the documentation of the PSL, I do not find a clear specification on what should be done with domains not found in the PSL. I assume it is application-specific. May be Domainatrex should return a different value for "not found"?
You could not check the public suffix list at all and just return :ok as these are valid domains. So do a pre-check to bypass it?
Hi @qannard - I'd be open to a PR which adds a new config option called allow_test which defaults to false, but the intended behaviour is to fail on domains which aren't in the public suffix list, which I believe is what is happening here.