quitting before starting the game leads to an exception in `ultramodern::join_saving_thread`

Question

quitting before starting the game leads to an exception in `ultramodern::join_saving_thread`

briaguya-ai opened this issue a month ago · comments

briaguya commented a month ago

Describe the bug

quitting before starting the game leads to an exception in ultramodern::join_saving_thread

To Reproduce

open the game to the launcher menu
quit

Expected behavior

the game exits gracefully

Screenshots

Wiseguy · Answer 1 · Mon Jun 10 2024 01:34:24 GMT+0800 (China Standard Time)

Thanks for the report. This is something that was introduced in the refactor to use N64ModernRuntime (so thankfully isn't in any of the releases), I just haven't had time to sort it out yet. Should just be a matter of not calling join_saving_thread if the game hasn't started, or starting the saving thread when the program opens instead of when the game starts.

briaguya · Answer 2 · Mon Jun 10 2024 01:43:11 GMT+0800 (China Standard Time)

yeah, i figure it's a decently quick fix, just something i've noticed a couple times so i figured making an issue instead of forgetting about it until i run into it again made sense

David Chavez · Answer 3 · Wed Jun 12 2024 15:40:52 GMT+0800 (China Standard Time)

This was fixed in the runtime which was updated in #392