rounding causes trouble...
jedierikb opened this issue · comments
Rounding the returned dimensions can cause trouble.
For example, I am using your observer to measure an element so I can fit a canvas element inside.
When the available space is fractional, the observer currently rounds up, and my resultant canvas is larger than its parent. Alas - unwanted scrollbars can result!
Maybe consider changing to returning the values without rounding?
hmm, interesting edge case.
I'm currently using "Math.round" (not rounding up), which should be how CSS resolves subpixel values.
The hook is also specifically done in a way so that it doesn't report every tiny subpixel change, which is why the rounding is in place to begin with.
Would having a way to opt out of rounding work for you?
Just note that having something like that would mean that your hosting component will get rerendered on each subpixel change.
(Unless you'd use the onResize function, in which case you could round the values however you like, and only trigger a render when necessary.)
I've also just stumbled upon this. The actual size of my element is 82.4px with a tiny overflow - useResizeObserver returns 82px which cuts off the element:
In this case, I wouldn't mind opting into using Math.ceil instead of Math.round - maybe a round option which accepts a function could be made available?
By default it could just use Math.round and everyone could either pass in Math.ceil, Math.floor or a custom function (for exact cases just an identity fn (a) => a would turn all rounding off and "opt in" to subpixel re-rendering).
What's your opinion on this @ZeeCoder @jedierikb?
Hmm, yeah I see the issue here.
Obviously rounding was put in place so that your component does not rerender on every subpixel change, but I see how it can cause issues.
I kinda thought that when people wanted to opt out of the default rounding behaviour, then they can just use the onResize callback.
However I understand that that would be more work, as you'd have to track size state then yourself in a custom hook, and opt out of rerenders when your custom rounding function produces the same value that's set at the time.
It shouldn't be too hard to add support for a custom function, and I don't see any immediate issues with it either.
Could be one that takes in both values at the same time, basically "processing" the reported values:
(w, h) => [newW, newH];
Then you could not only process the values differently, but do other fancy things like keeping an aspect ratio:
(w, h) => [w, w * 1.5]
Not sure how useful that is though.
I like the idea of passing in a custom function :-)
Hi @vaniya-k ,
I'm glad you find the lib useful, that means a lot, thank you. 🙏
I'm really sorry but I can't really promise anything for the nearby future, as I'm expecting my daughter to be born in mid June and I can't justify the time spent on the project right now.
I do have a bigger update that'd clear out all the pending issues / PRs, but I'm just not sure I'll get the right time for it.
For the time being I'd recommend implementing your own wrapper hook, which would implement onResize with local state, so that you can do the rounding any way you like.
Then once this lib would come out with a fix, you could just replace your internal implementation with a direct useResizeObserver call for a seemless transition.
oh boy, you do have much more on your plate than an average open source creator / maintainer)) wish you all the best with the upcoming addition to your family!))
no worries, we have a good-enough workaround, just wanted to inquiry on the roadmap
Thanks, really appreciate it 🙏
🎉 This issue has been resolved in version 8.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀