Use a single ResizeObserver instance

Question

Use a single ResizeObserver instance

ZeeCoder opened this issue 5 years ago · comments

Viktor Hubert commented 5 years ago

Seems like it's more performant and the recommended pattern:
WICG/resize-observer#59

Elena Rashkovan · Answer 1 · Tue Dec 10 2019 21:23:12 GMT+0800 (China Standard Time)

Related – #26

Viktor Hubert · Answer 2 · Sun Oct 11 2020 20:59:03 GMT+0800 (China Standard Time)

I'm not convinced yet whether this is an optimisation that's actually worth it or not.
I've only seen a single benchmark that seem to indicate that it might be better to use a single RO for all hook instances,
but it wasn't convincing enough to warrant the associated work.

I'd need a way to test this somehow for myself for a large number of observed elements and measure CPU / memory usage maybe, to see if there's a difference between using one or many RO instances.

Viktor Hubert · Answer 3 · Sun Oct 11 2020 21:00:00 GMT+0800 (China Standard Time)

Or if there was a comprehensive test / article / benchmark that demonstrated that using a single RO instance is significantly better, then I would consider it.

Viktor Hubert · Answer 4 · Sat Nov 14 2020 00:39:13 GMT+0800 (China Standard Time)

I forgot about this one:
que-etc/resize-observer-polyfill#13 (comment)

Seems like there's something in there, but I'd still need a way to benchmark CPU + memory usage, so that I could compare a results of the current implementation to one that uses a single instance.

Viktor Hubert · Answer 5 · Sat Nov 14 2020 00:41:19 GMT+0800 (China Standard Time)

I'd really appreciate someone well-versed in benchmarking UI to help out.