Exit inside non-main function

Question

Exit inside non-main function

uzaxirr opened this issue 2 years ago · comments

Description

Packages exposing functions that can stop program execution by exiting are hard to reuse. Program exits in functions other than main() or init() are not encouraged.

Occurrences

There are 4 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/ZeStream/zestream-server/issue/RVV-A0003/occurrences/

Solution

calls to log.Fatal should be only in main() or init() functions. So a possible solution for this could be replacing log.Fatal with an Error log level

Missing-Parallax · Answer 1 · Wed Jan 04 2023 00:15:12 GMT+0800 (China Standard Time)

I want to work on this

Akshat Sharma · Answer 2 · Sat Jan 07 2023 23:47:54 GMT+0800 (China Standard Time)

Hey @Missing-Parallax are you still working on this? If not I'd like to pick this up :)

Missing-Parallax · Answer 3 · Sat Jan 07 2023 23:49:46 GMT+0800 (China Standard Time)

Sure Akshat, u can take it.

…

On Sat, Jan 7, 2023 at 9:18 PM Akshat Sharma ***@***.***> wrote: Hey @Missing-Parallax <https://github.com/Missing-Parallax> are you still working on this? If not I'd like to pick this up :) — Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AY76OTUMFKWWESDIH4KEGYDWRGF3LANCNFSM6AAAAAATPKLVN4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Uzair Ali · Answer 4 · Sun Jan 08 2023 00:28:34 GMT+0800 (China Standard Time)

Hey @akshat2602
I've assigned the issue to you!