Giters

Zacharysp / CalendarHeatmap

A calendar based heatmap which presenting a time series of data points in colors.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

StartDate is being overridden

glancashire opened this issue · comments

commented

Hi Zachary

me again.

You are overriding the startDate, that I am lovingly calculating.

HeatmapCalendar.swift > function private func setup(completion: @escaping () -> Void) {
startDate: self.startDate.startOfMonth(),

Is there an option of making this optional ;-)

Kind Regards
Graham

commented

yes, the first date of the calendar is actually the first date of the month based on the provided startDate. I thought it looks nice considered in a Calendar.

But second thought, it should not be included as a pure calendar framework, I will remove this part and let the user do the calculation.

commented

Hi Zachary

Thanks for you very constructive reaction.

Graham