YunoHost-Apps / wallabag2_ynh

Wallabag v2 package for YunoHost

Home Page:https://www.wallabag.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve backup logs

lapineige opened this issue · comments

There is a recommendation here : https://ci-apps-dev.yunohost.org/ci/job/783

- We recommend to *not* use 'ynh_script_progression' in backup scripts because no actual work happens when running the script : YunoHost only fetches the list of things to backup (apart from the DB dumps which effectively happens during the script...). Consider using a simple message like this instead: 'ynh_print_info "Declaring files to be backed up..."'

We could improve that logging operation during backup script, based on this recommendation.
(I have no time to work on this, I'm referencing it as it's 1) not pressing at all and 2) a good first contribution if someone want to try 🙂)

Fixed by #118