OTPListener interface not accessible outside the com.yubico.yubikit.otp package

Question

OTPListener interface not accessible outside the com.yubico.yubikit.otp package

tonydailallscripts opened this issue 4 years ago · comments

tonydailallscripts commented 4 years ago

I created a Xamarin binding for Yubikit and otp packages. I am unable to implement the interface since it does not have an access modifier and it defaults to private. I made it public in my local repository and it resolves the issue.

imakhalova · Answer 1 · Sat Apr 25 2020 04:28:42 GMT+0800 (China Standard Time)

Valid point. Please feel free to submit pull request with this change.

tonydailallscripts · Answer 2 · Mon Apr 27 2020 21:23:49 GMT+0800 (China Standard Time)

I do not have commit privileges.

Ludwig Ward · Answer 3 · Thu Apr 30 2020 02:19:37 GMT+0800 (China Standard Time)

Thank you for your feedback! We are investigating if the change would have any unwanted effects and will accommodate the change in the next RC, which is currently planned for end of next week.

Feel free to reach out if you have any further feedback or questions.

Dain Nilsson · Answer 4 · Thu Jun 04 2020 18:27:15 GMT+0800 (China Standard Time)

After some investigation we determined that this class and some other related ones shouldn't be extended by the user, and some access modifiers have been changed to reflect that.