Buffer is not defined error

Question

Buffer is not defined error

ysds opened this issue 2 years ago · comments

Shohei Yoshida commented 2 years ago

"When I run the "todo-simple-react" example and try to add a todo, I get the following error.

This may be related to this.
webpack/changelog-v5#10

Yousef · Answer 1 · Fri Oct 28 2022 21:03:51 GMT+0800 (China Standard Time)

Thanks @ysds,

Do you get the same error on https://klwxt.csb.app/, or only when you build it yourself?

The current version of Matrix-CRDT doesn't use webpack anymore (we have migrated to Vite)

Shohei Yoshida · Answer 2 · Tue Dec 06 2022 09:25:42 GMT+0800 (China Standard Time)

Sorry for the late reply.
I was unable to open the demo for a while due to the "TypeError Could not fetch dependencies, please try again in a couple of seconds" issue in codesandbox.

Now I can access that demo without any problem and I can't confirm the Buffer issue.

Also, I raised my local Node version from v16 to v18 and this problem did not occur.

Matt Good · Answer 3 · Thu Dec 29 2022 02:28:21 GMT+0800 (China Standard Time)

I'm seeing the same issue when trying to set this up with a SvelteKit/Vite project.

"matrix-crdt": "^0.2.0",
"matrix-js-sdk": "^22.0.0",

I added this Buffer polyfill to get around the problem for now:
https://github.com/feross/buffer

I see there's another location in the code using lib0/buffer.fromBase64 which seems like it might be a suitable replacement for the base64 encoding/decoding that would work in the browser without a polyfill.

Yousef · Answer 4 · Mon Jan 16 2023 04:32:22 GMT+0800 (China Standard Time)

Added a Vite example now that shows how you can set it up, see this note in the main Readme:

Note for Vite / non-webpack If you're using Vite, or other non-webpack builds, note that matrix-js-sdk depends on certain polyfills available. See the Vite example and matrix-org/matrix-js-sdk#2903.