Yoast / wordpress-seo

Yoast SEO for WordPress

Home Page:https://yoast.com/wordpress/plugins/seo/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Undefined index: orderby

kkmuffme opened this issue · comments

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

Undefined index: orderby

To Reproduce

Step-by-step reproduction instructions

wordpress-seo/admin/class-meta-columns.php on line 458

Error URL: https://foo.com/wp-admin/edit.php?post_type=shop_order
Trace:
1. /path/wp-includes/class-wp-hook.php (324): WPSEO_Meta_Columns->column_sort_orderby( $vars = Array( [posts_per_page] => 20, [post_type] => shop_order ) )
2. /path/wp-includes/plugin.php (203): WP_Hook->apply_filters( $value = Array( [posts_per_page] => 20, [post_type] => shop_order ), $args =

Array(
  [0] => Array(
      [posts_per_page] => 20
      [post_type] => shop_order
    )
)
)
3. /path/wp-includes/class-wp.php (409): apply_filters( $hook_name = 'request', $value = Array( [posts_per_page] => 20, [post_type] => shop_order ) )
4. /path/wp-includes/class-wp.php (821): WP->parse_request( $extra_query_vars = Array( [post_type] => shop_order, [posts_per_page] => 20 ) )
5. /path/wp-includes/functions.php (1337): WP->main( $query_args = Array( [post_type] => shop_order, [posts_per_page] => 20 ) )
6. /path/wp-admin/includes/post.php (1310): wp( $query_vars = Array( [post_type] => shop_order, [posts_per_page] => 20 ) )
7. /path/wp-admin/includes/class-wp-posts-list-table.php (207): wp_edit_posts_query()
8. /path/wp-admin/edit.php (235): WP_Posts_List_Table->prepare_items()

Expected results

no notice

Actual results

PHP notice

Hi @kkmuffme

We use GitHub exclusively for well-documented bug reports or feature requests. The reported issue does not contain enough information to be a viable bug report or feature request, as you haven't mentioned how to reproduce it. Thus, we're now closing the report.

We have the following support channels:

If you feel like your bug or enhancement is valid and should be reviewed by us, please use the provided templates by sharing more details on how to reproduce the issue, read our contribution guidelines, and submit a new issue.

Thank you for your understanding.

The reported issue does not contain enough information to be a viable bug report or feature request, as you haven't mentioned how to reproduce it

I provided the URL
and a partial stack trace.

For this error neither is necessary, since this is an issue you'd get reported by any static analysis tool already.

The provided details are more than sufficient to fix the issue.