Yelp / MOE

A global, black box optimization engine for real world metric optimization.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue warnings in multistart_hyperparameter_optimization of python version

yf275 opened this issue · comments

commented

Hi,

For the one in optimal_learning/python/python_version/log_likelihood.py, Line 107 is trying to apply numpy.log10 on hyperparameter_optimizer.domain._domain_bounds. I think we should issue a warning to users when they include negative values in domain_bounds so numpy.log10 would return a number instead of nan Similar thing for Line 128 of log_likelihood.py in optimal_learning/python/cpp_wrappers/log_likelihood.py.

Sorry I've been gone for so long! See: #448 for details.

This is similar to #446, I think. Sorry, yes MOE's input validity checking isn't very thorough.