GabrielDelepine / angular-css-injector

A angularJS service to load dynamically CSS files

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Not compatible with Angular 1.3?

fmalk opened this issue · comments

I can't get it to work with Angular's latest version. Bower makes me choose between the required 1.2.6 from this project, or use my current 1.3. Installs fine if I choose 1.3, but breaks my controllers just by injecting it into a module.
Is it really not compatible at this point?

Hi @fmalk,

I haven't check it yet with Angular 1.3 . If you find a way to fix the issue I will appreciate a PR.
I will mention the problem in the readme.

Thanks

It works on 1.3.0. I'm using it.

When trying to use angular app (1.3.6) without debug info

$compileProvider.debugInfoEnabled(false);

then I get the following error:

angular.css.injector error : Please initialize your app in the HTML tag and be sure your page has a HEAD tag.

Otherwise it looks it works.
@yappli Do you intend to add support on 1.3.x?

@avgustint: I had the same error when I initialize ng-app anywhere else than in the -tag. Put it there and it might work.

Angular 1.3.13 works fine here. If it doesn't work for you, maybe you can provide an example of the error?

Angular 1.3.11 works fine here with css-injector v1.0.3.1.

I'm using <html id="HwwApp" ng-controller="AppCtrl"> and then bootstrap the app manually on deviceready (building with PhoneGap)

Anyways. I'm currently looking to switch over to AngularCSS, since it provides a wealth of features, like injecting CSS based on active routes or directives. Maybe you could join forces?

It works with angular v1.3.6
Here the example

http://plnkr.co/edit/7PBpffxfIpsVW9GpXAXT?p=preview