YaleDHLab / pix-plot

A WebGL viewer for UMAP or TSNE-clustered images

Home Page:https://s3-us-west-2.amazonaws.com/lab-apps/pix-plot/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Lasso and Picker should cooperate

kruus opened this issue · comments

  1. deselections in View Selected currently change this.selected. This means clicking images following n deselected images are out-by-n and display the wrong image. Ex. If you deselect the first image, all remaining ones are out-by-one when asking for the detailed view.
  2. deselections (and new number selected) should get reflected in main display on closing View Selected window
    • currently if you create a new cluster, you get the correct-but-not-as-displayed version.
  3. lasso and picker (Shift + Click) should cooperate (i.e. lasso and shift-click can toggle individual images to the selected ones)
    • I ended up using Ctrl-drag for lasso, iirc, because it was easy for me to make mistakes between Shift-Click and Shift-Drag and lose some possibly detailed work.

Anyway, code was clear enough that I've a decent "good enough for now" version addressing above.

Thanks very much for this writeup @kruus! We should be able to clean some of this up next week...

Please keep the issues rolling if you spot other unexpected behavior!

Maybe you can come up with something cleaner/faster.

Other issue: Does your hotspot scrollbar work? Mine was not appearing. Fixing mostly involved adjusting styles.css width issues and one ugliness for scrollbar height. Mine works now, but my adjustments were super-ugly -- I really just poked at it until it worked.

Excellent timing -- I'm taking vacation next week, while you work on this!

Hi Kruus! Quick question on the scrolling -- sounds like you both don't have a visual scrollbar, and that mousewheel/trackpad drag is not moving the list of hotspots up and down correctly? Also, could you tell us your platform and browser? Thanks!