Xilinx / embeddedsw

Xilinx Embedded Software (embeddedsw) Development

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Macro expansions with missing parantheses in xqspips.h

asahin24 opened this issue · comments

In xqspips.h
In all macro expansions, InstancePtr is wrapped up with paranthesis except

  • XQspiPs_Enable
  • XQspiPs_Disable
  • XQspiPs_GetTXWatermark
  • XQspiPs_GetRXWatermark

All macro expansions (except these) can be called with argument "&QspiInstance".

//Example:
XqspiPs QspiInstance;
XQspiPs_GetLqspiConfigReg(&QspiInstance)

If I call these macro expansions the same way, compiler raises Error :

base operand of '->' has non-pointer type 'XQspiPs' xqspips.h

I should call them with extra paranthesis:

XQspiPs_Disable((&QspiInstance));

It took some time for me to realize the problem.
It would be nice to be able to call all of them the same way

Hello @asahin24

Thank you for bring this to our notice. Its a vaild issue and we will fix in next release