Issue with RFDC device tree generator parameter names
litghost opened this issue · comments
Configuration
Vivado/PetaLinux/device-tree-xlnx at 2023.2 on Ubuntu 20.04
Expected behavior
Device tree writer correctly outputs NCOFreq parameters into device tree param-list
.
Actual behavior
Device tree writer outputs NCOFreq as "0.0" to device tree param-list
.
Issue
Between 2022.2 and 2023.2 the device tree writer for the RFDC driver added the NCOFreq parameter (see commit). However that commit reads from a parameter named C_DAC_NCO_FREQ00
(and C_DAC_NCO_FREQ01
, etc). However Vivado appears to believe this parameter is named C_DAC_NCO_Freq00
(and C_DAC_NCO_Freq01
, etc).
When the device tree generator is run on a design that contains an usp_rf_data_converter
block, the device tree writer complains about not finding the relevant configuration:
WARNING: [Common 17-673] Cannot get value of property 'CONFIG.C_DAC_NCO_FREQ00' because this property is not valid in conjunction with other property setting on this object.
When checking the output device tree param-list
, the output has all the NCO frequencies at 0.0 instead of the correct value.
As an experiment, I changed rfdc.tcl
to use C_DAC_NCO_Freq00
instead of C_DAC_NCO_FREQ00
, and this appears to resolve this issue. I suspect rfdc.tcl
needs to updated to use the names used in Vivado?
Hi,
Thank you for your comment, we will include this fix in the upcoming release.
Thanks & Best Regards,
Conall.