XFsbl_PollTimeout function only checks the condition once

[Philip Van Baren]

The commit ID 59f1dda "sw_apps :zynqmp_fsbl: Re-structured Xil_poll_timeout macro as XFsbl_PollTimeout function." changed a macro into a function. However one of the arguments to the macro was the condition which is supposed to be checked repeatedly during the loop. As a result of the change from macro to function, the condition is only checked once, prior to executing the function. The result is that if the condition is true prior to the loop, the poll will succeed. If the condition is false prior to the loop, the poll will time out.

The simple fix is to revert the above referenced commit, and restore the expected behavior using the macro.

[SaratCS]

@pvanbaren , thanks for reporting. We're looking into this and will fix as required.