XiaoMi / naftis

An awesome dashboard for Istio built with love.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reloader sidecar in naftis-api fails to reload promviz configuration

supereagle opened this issue · comments

Describe the bug
naftis-api does not provide reload api, so the sidecar reloader fail to reload promviz configuration by reload url http://localhost:50000/reload.

Error from naftis-api:

$ kubectl -n naftis logs -f --tail 50  naftis-api-0 naftis-api
[GIN] 2018/12/01 - 11:56:55 | 200 |      71.096µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:56:56 | 200 |     121.448µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:01 | 404 |       2.013µs |             ::1 | POST     /reload
[GIN] 2018/12/01 - 11:57:05 | 200 |      94.056µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:06 | 200 |      68.985µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:15 | 200 |      144.69µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:16 | 200 |      74.286µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:25 | 200 |     249.232µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:26 | 200 |      61.465µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:35 | 200 |      91.104µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:36 | 200 |     163.875µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:39 | 404 |       1.813µs |             ::1 | POST     /reload
[GIN] 2018/12/01 - 11:57:45 | 200 |     116.342µs |  192.168.21.103 | GET      /api/probe/healthy
[GIN] 2018/12/01 - 11:57:46 | 200 |     115.269µs |  192.168.21.103 | GET      /api/probe/healthy

Error from reloader:

$ kubectl -n naftis logs -f --tail 50  naftis-api-0 reloader
{"level":"info","ts":1543665367.378195,"caller":"k8s-config-reloader/main.go:106","msg":"Starting reloader...","component":"reloader"}
{"level":"warn","ts":1543665367.5766084,"caller":"k8s-config-reloader/main.go:144","msg":"Failed to reload promviz configuration","component":"reloader","error":"Received response code %!s(int=404), expected 200","next retry":0.507739337}
{"level":"warn","ts":1543665368.180896,"caller":"k8s-config-reloader/main.go:144","msg":"Failed to reload promviz configuration","component":"reloader","error":"Received response code %!s(int=404), expected 200","next retry":1.047383961}
{"level":"warn","ts":1543665369.4312794,"caller":"k8s-config-reloader/main.go:144","msg":"Failed to reload promviz configuration","component":"reloader","error":"Received response code %!s(int=404), expected 200","next retry":1.217617209}
{"level":"warn","ts":1543665370.6576612,"caller":"k8s-config-reloader/main.go:144","msg":"Failed to reload promviz configuration","component":"reloader","error":"Received response code %!s(int=404), expected 200","next retry":0.916087631}

To Reproduce

Naftis: v0.1.3
Istio: v1.0.0
Kubernetes: v1.10

Expected behavior
There is no error.

Screenshots
If applicable, add screenshots to help explain your problem.

Environments (please complete the following information):

  • OS: [e.g. Linux]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 0.1.3]

Additional context
Add any other context about the problem here.

commented

@supereagle we will fix it later.

@sevennt Thanks 👍

commented

@supereagle we have already removed k8s-config-reloader, since we do not need it any more.

commented

@supereagle I close the issue now, if you have any problems, open it again.