Giters

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.

Home Page:https://xiangyu-hu.github.io/SPHinXsys/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Crash with without error message when regression data not written.

Xiangyu-Hu opened this issue · comments

commented

The regression test class is defined but not used to output data.
For example in the water exit case, one define the test:

SPHinXsys/tests/2d_examples/test_2d_water_entry_exit/test_2d_water_entry_exit.cpp

Lines 392 to 393 in d85a5e6

RegressionTestDynamicTimeWarping<ObservedQuantityRecording<Real>>
write_cylinder_wetting("Phi", io_environment, wetting_observer_contact);

But forget to write the output file, and still try to generate the regression test data by:

SPHinXsys/tests/2d_examples/test_2d_water_entry_exit/test_2d_water_entry_exit.cpp

Line 538 in d85a5e6

write_cylinder_wetting.generateDataBase(1.0e-3);

When I run the python script, I obtained crash information, but not able find the reason,
that I actually have not write out data.
Therefore, we need an error handler so that one can notice that the data file was not written.

commented

I will have a look on that.

commented

Another issue is that there is repeating data, the the reading the xml lead to error and and the regression data can nor be generated.

commented

@Bo-Zhang1995 Please look the these bugs.

commented