Giters

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.

Home Page:https://www.sphinxsys.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

obvious repeat on define diffusion particles and material

Xiangyu-Hu opened this issue · comments

commented

The two lines shows that

SPHinXsys/tests/2d_examples/test_0d_regression_test/regression_test.cpp

Line 112 in 751280b

using DiffusionParticles = DiffusionReactionParticles<SolidParticles, DiffusionMaterial>;

and

SPHinXsys/tests/2d_examples/test_0d_regression_test/regression_test.cpp

Line 201 in 751280b

diffusion_body.defineParticlesAndMaterial<DiffusionParticles, DiffusionMaterial>();

repeat the use of diffusion material.

commented

I will revise this by: 1. using single type for all particles, 2. the variables will be registered in diffusion-reaction material or in diffusion reaction methods.