XhmikosR / notepad2-mod

LOOKING FOR DEVELOPERS - Notepad2-mod, a Notepad2 fork, a fast and light-weight Notepad-like text editor with syntax highlighting

Home Page:https://xhmikosr.github.io/notepad2-mod/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

undo does not preserve selection

kofifus opened this issue · comments

select text, delete and undo, the selection is gone.

This happens in notepad2-mod, notepad2 and notepad++ but does not happen in almost any other editor I checked.

Thanks!

I'm interested in this ticket and would like to work on. May I know how I can pick this item? Need any confirmation first before going ahead? :-)

two comments:

First, this is already done in notepad2beta, see http://www.flos-freeware.ch/development-releases/notepad2-ChangeLog.txt

So the way to go is to ask flo for the sources for notepad2 beta then get the delta from notepad2 and merge it in.

Second, I'm not sure of this but it seems notepad3 is the replacement for notepad2mod, so perhaps it's better to work towards a PR there ?

Got it. I'll go to notepad3 repository and see if there's any other items I can work on. Thank you very much. :-)

It is a Scintilla problem
(see Feature Request (dated 2011): https://sourceforge.net/p/scintilla/bugs/1224),
which has been rejected by the maintainers of the Scintilla library.
Reason: Cut is implemented on document-level, Selection is on view-level.
To solve this problem, the level connecting implementation (NP2's source code) has to
solve it. This cannot be easily done, cause NPn's undo/redo stack
completely relies on Scintillas document-level implementation ...
Flo (the developer of original NP2) managed to implement it for NP2 v.5.0.26-beta4,
but the sources are not available ... :-/

Maybe worth while asking Flo for the beta sources

great!