Giters

XhmikosR / find-unused-sass-variables

A simple tool to find unused Sass variables

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Different number of variables on Windows/Linux shell

XhmikosR opened this issue · comments

commented

On Ubuntu:

> node ./cli.js tests/ --ignore="$a,$b"

Looking for unused variables
Searching for unused variables in "/home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests" folder, scss files...
11 total variables.
8 are not used!
Variable $a is not being used! /home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:2
Variable $b is not being used! /home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:3
Variable $unused is not being used! /home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:4
Variable $black is not being used! /home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:5
Variable $ignored-variable is not being used! /home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:13
Variable $enabled-variable is not being used! /home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:19
Variable $nestedVar is not being used! /home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests/test.scss:7
Variable $nestNestedVar is not being used! /home/runner/work/find-unused-sass-variables/find-unused-sass-variables/tests/test.scss:12

On Windows:

> node ./cli.js tests/ --ignore="$a,$b"

Looking for unused variables
Searching for unused variables in "D:\a\find-unused-sass-variables\find-unused-sass-variables\tests" folder, scss files...
9 total variables.
6 are not used!
Variable $unused is not being used! D:/a/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:4
Variable $black is not being used! D:/a/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:5
Variable $ignored-variable is not being used! D:/a/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:13
Variable $enabled-variable is not being used! D:/a/find-unused-sass-variables/find-unused-sass-variables/tests/_variables.scss:19
Variable $nestedVar is not being used! D:/a/find-unused-sass-variables/find-unused-sass-variables/tests/test.scss:7
Variable $nestNestedVar is not being used! D:/a/find-unused-sass-variables/find-unused-sass-variables/tests/test.scss:12

It seems that the ignore CLI option isn't respected on Linux. Maybe we need to escape $?

commented

So, it seems that on Ubuntu ignores aren't respected at all. Unsure if it's a combination of our npm test script and Ubuntu or if it happens with normal CLI usage on Ubuntu too.