WorldHealthOrganization / app

COVID-19 App

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Consider using instance id api to properly sync notification topics

advayDev1 opened this issue · comments

Given that country changing is now allowed, the topic management code is fragile.

Instead of keeping track of which topics are subscribed to in the user db, instead go to the source of truth: https://developers.google.com/instance-id/reference/server#get_information_about_app_instances and add or remove topics based on that list.

Agreed. This part of the system definitely needs an overhaul.

I will take a look monday

Added comments for what i remember @matthewblain

commented

This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.