WorldHealthOrganization / app

COVID-19 App

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Indentation on bullet points

msaini888 opened this issue · comments

Steps to reproduce the behavior:

  1. Launch the app
  2. Complete Onboarding journey.
  3. Tap on Learn tab in the footer.
  4. Tap on Questions & Answers
  5. Expand the section which says "What should I do if I have been exposed to someone who has COVID-19?"

Expected Behavior
Text Alignment should be proper

Actual Behavior
Text Alignment is not proper.

System

  • Device: Huawei Honor 7c
  • OS: Android 8.0
  • App Version: version 1.0.0-staging(281)

Screenshots

Screenshot_20201220-191403

Checklist:

@Mohit020888 and @brunobowden can please assign me this issue I would love to work on this issue :)

Thanks

@champ96k - thanks for volunteering to fix this one as well !
I have assigned it to you 👍

@Mohit020888 @champ96k - it's going to be important that this looks good on very small screens. So please post a screenshot as part of any PR. Perhaps fixing the indentation will look better.... but also reduce the margin to the left of the bullet points as well.

My concern in part is that "unordered lists" or <ul> exist throughout the app content. So this should be a general fix for everything and not just this single page. See search results for all the content examples:
https://github.com/WorldHealthOrganization/app/search?q=%3Cul%3E

@brunobowden, @Mohit020888 Thanks for the detailed explanation, I definitely take care of all things

@champ96k - main thing is that if the change starts looking too complex, then I'd question whether it's worth doing anything at all. It may be that the additional complexity is brittle and hard to maintain, which doesn't make sense for the product. See what you experiment with and feel free to share some preliminary before it takes up too much of your time.

@brunobowden, @Mohit020888, The current flutter html is still not supported for Indentation on bullet points, as someone created PR on flutter html Add support for inline styles to new parser but still flutter html is not supported for html unordered list Indentation on bullet points

Then I used flutter_widget_from_html and it's work as you can see on the given screenshot

System

Device: Redmi 8A
OS: Android 9.0

Screenshot:

Screenshot

Please let me know anything want to update or change

Thanks :)