Bug: texContent -> textContent

Question

Bug: texContent -> textContent

greghuc opened this issue 7 months ago · comments

Gregory Huczynski commented 7 months ago

I tracked back a v4 error to https://github.com/WebReflection/uhtml/blob/main/esm/handler.js#L179

'texContent' should be 'textContent'

Andrea Giammarchi · Answer 1 · Tue Nov 14 2023 17:18:18 GMT+0800 (China Standard Time)

thanks ... I really should bring back tests and coverage ... it's just that linkedom might not have it all for the SVG case but I will eventually do that ... everything else has been manually tested (except this one, apologies).

Fixed in latest.

Gregory Huczynski · Answer 2 · Tue Nov 14 2023 17:50:57 GMT+0800 (China Standard Time)

@WebReflection no worries, and thanks for uhtml. It's great.

Andrea Giammarchi · Answer 3 · Wed Nov 15 2023 01:21:25 GMT+0800 (China Standard Time)

@greghuc just FYI the 100% linkedom based test coverage is back with even more tests so I hope stability now is at pair with what I had before. Most test pages have been updated too (just swapped global leak with a proper module) and everything looks fine to me. Thanks for your patience.

Gregory Huczynski · Answer 4 · Wed Nov 15 2023 02:34:47 GMT+0800 (China Standard Time)

@WebReflection that's great there are more tests. I always feel more confident refactoring when I know tests will catch the breakages. I've switched my main app to use v4, so will look out for any more issues.