cdata-section beaks esm import

Question

cdata-section beaks esm import

jefbarn opened this issue 9 months ago · comments

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '.../linkedom/esm/interface/cdata-section' imported from .../node_modules/linkedom/esm/shared/facades.js

The facades.js file needs the cdata import to have the '.js' extension.

https://github.com/WebReflection/linkedom/blob/6f21a9df53e12431a1a38f0974c69b4fb9ee57ce/esm/shared/facades.js#L3C74-L3C74

Bart Veneman · Answer 1 · Tue Oct 24 2023 01:55:11 GMT+0800 (China Standard Time)

Having the same issue in 0.16.0. Version 0.15.6 is not affected by this issue.

Andrea Giammarchi · Answer 2 · Tue Oct 24 2023 15:30:38 GMT+0800 (China Standard Time)

damn it TS users ...

Andrea Giammarchi · Answer 3 · Tue Oct 24 2023 15:34:05 GMT+0800 (China Standard Time)

apologies I should've paid more attention, not even sure why tests pass there ... fixed now.

Andrea Giammarchi · Answer 4 · Tue Oct 24 2023 15:35:26 GMT+0800 (China Standard Time)

not even sure why tests pass there

FWIWI actually I know why, CJS does the same, it fallsback to .js so no problems whatsoever there ... bummer, this should've been caught earlier. Sorry again.

Andrea Giammarchi · Answer 5 · Tue Oct 24 2023 15:38:13 GMT+0800 (China Standard Time)

OK, this should never happen again.

Bart Veneman · Answer 6 · Tue Oct 24 2023 18:40:58 GMT+0800 (China Standard Time)

Hey, no worries, thanks for the quick fix + tests!