WebReflection / linkedom

A triple-linked lists based DOM implementation.

Home Page:https://webreflection.medium.com/linkedom-a-jsdom-alternative-53dd8f699311

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

cdata-section beaks esm import

jefbarn opened this issue · comments

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '.../linkedom/esm/interface/cdata-section' imported from .../node_modules/linkedom/esm/shared/facades.js

The facades.js file needs the cdata import to have the '.js' extension.

https://github.com/WebReflection/linkedom/blob/6f21a9df53e12431a1a38f0974c69b4fb9ee57ce/esm/shared/facades.js#L3C74-L3C74

Having the same issue in 0.16.0. Version 0.15.6 is not affected by this issue.

damn it TS users ...

apologies I should've paid more attention, not even sure why tests pass there ... fixed now.

not even sure why tests pass there

FWIWI actually I know why, CJS does the same, it fallsback to .js so no problems whatsoever there ... bummer, this should've been caught earlier. Sorry again.

OK, this should never happen again.

Hey, no worries, thanks for the quick fix + tests!