WebDevStudios / wp-search-with-algolia

Improve search on your site. Autocomplete is included, along with full control over look, feel and relevance.

Home Page:https://wordpress.org/plugins/wp-search-with-algolia/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

FSE compatible template files

tw2113 opened this issue · comments

What can we do to help make sure our template files is Full Site Editing compatible?

For the instantsearch.php file, we have get_header() and get_footer() calls, but also some internationalized Algolia widget titles that make use of PHP calls.

For the autocomplete.php, mostly just internationalization.

I think this could be easy-ish, but I am making no guarantees on that.

Extra thoughts: this probably won't be a case of modifying the existing PHP files, but making FSE compatible equivalents that we could perhaps ship with the plugin alongside the current PHP versions.

commented

Isn't this the same as this issue?

@peiche yes, forgive me for forgetting about that ticket from you. I will get these merged in a sense.

Closing in favor of #216