WayfireWM / wf-config

A library for managing configuration files, written for wayfire

Home Page:https://wayfire.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wayfire crashes if plugins option is not defined in core section of config file

soreau opened this issue · comments

what(): No such option: core/plugins

This doesn't happen with any option that is defined in the xml files, only with ones that aren't, such as this one.

This is the expected behavior, we have simply missed this option in the config file (note this happens because of missing options XMLs).

Wait, I thought missing options were a hard error in wf-config.. is this no longer the case?

Yes, exactly, and this is such an error. However keep in mind you can have options with no XMLs - for example, output config options, because you don't know their names in advance. In that case however, one should not use option wrapper.

Hm, you're right. We just should assert that there is a XML node for each option from option wrapper

Oh right, this is what happens when an option isn't found in neither the xml nor the config file.

Changed my mind again, it is perfectly fine to have option_wrapper for options which do not come from the XML files (if for example options are programatically added)