Giters

WasatchPhotonics / ENLIGHTEN

Open-source spectroscopy application for controlling and taking measurements from Wasatch Photonics spectrometers.

Home Page:https://wasatchphotonics.com/product-category/software/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build instructions do not work "out of the box"

jkleinwp opened this issue · comments

commented
  • Build instructions do not work "out of the box" on Windows 11 or Mac
  • Not all requirements are captured and the user must manually install extra packages
  • rebuild_resource.sh script works on Mac but not Windows
  • BUILD_WINDOWS.md doesn't capture exactly what console tool should be used (e.g. Git BASH, command prompt, Power Shell); instructions/scripts do not work correctly in all these tools
commented

This is how I run rebuild_resources.sh on Windows (using Git for Windows Cmd shell).
image

commented

My results (Windows 11 Home):

  • Git CMD console: 'sh is not recognized as internar or external command'. This is a fresh install of Git, so I must have to add sh executable to the path.
  • Git BASH: cannot find pyside executables in scripts/enlighten_py311 virtual environment. The code that checks for the executable should be in double quotes to prevent globbing/word splitting (see this)

Changing:
(109) if ! [ -f $RCC ]

to
(109) if ! [ -f "$RCC" ]

Resolves this issue. I think it's probably triggered by differences in our paths since my files are under a user directory that has a space in it.