JUnit is leaked on debug classpath
Raenar4k opened this issue · comments
Describe the bug
I had issues with running LeakCanary on our build because it detects JUnit on our debug classpath.
We setup all test dependencies properly - so we check where junit is coming from.
As you can see, one of dependencies of Wallet Connect is using junit and leaking it in classpath: com.github.komputing.kethereum
![image](https://private-user-images.githubusercontent.com/13849790/336794955-a3440b4c-870b-4c2b-bcbb-55db93098f06.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4MzQ4NjYsIm5iZiI6MTcyMzgzNDU2NiwicGF0aCI6Ii8xMzg0OTc5MC8zMzY3OTQ5NTUtYTM0NDBiNGMtODcwYi00YzJiLWJjYmItNTVkYjkzMDk4ZjA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE2VDE4NTYwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFkMThmMjA0MTMyZThiM2E2ZTE1Y2Y1ZTEwNWE0NGY5ZWU2MWRmMTQ5NmZkNTlmNWFjNzQwMTk0YTE5NWNkY2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5AbZZ549XfEiTqw3n6ExwgbyhNvzGI30QSvPBcMuWgM)
SDK Version
- Client: Kotlin
- Version
1.31.4
As a workaround for now i just remove junit from WC dependency:
implementation(platform(libs.walletconnect.bom))
implementation(libs.walletconnect.android) {
exclude(group = "org.bouncycastle", module = "bcprov-jdk15on")
exclude(group = "junit", module = "junit")
}
implementation(libs.walletconnect.sign) {
exclude(group = "org.bouncycastle", module = "bcprov-jdk15on")
exclude(group = "junit", module = "junit")
}