WFCD / warframe-items

📘 Get all Warframe items directly from Warframe's API. No more messy wikia scraping.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

:rocket: Hash data from DE to determine if updates are needed

TobiTenno opened this issue · comments

commented

Is your enhancement request related to a problem? Please describe.
Essentially, we publish too many releases

Describe the upgrade you'd like
Update data if DE's data has updated, so we need to hash their origin data. I'd think the hash in their URL is adequate, possibly, but we'd need to store a hash per-manifest file, but that shouldn't be that bad.

example, in the url...
http://content.warframe.com/PublicExport/Manifest/ExportWeapons_en.json!00_fJwSHnUxX1w6f4exHJ0Z9g
we need to store a key of ExportWeapons_en.json with a key of 00_fJwSHnUxX1w6f4exHJ0Z9g, so we'd just have to check if 00_fJwSHnUxX1w6f4exHJ0Z9g has changed when we pull new copies of ExportWeapons_en.json if we want to update it. If no changes are detected, don't run any of the build process.

Ideally, we'd be able to just update the parts that are updated with changed hashes, but our build process wouldn't allow that.

Describe alternatives you've considered
Hashing all of our data after build, but this seems pretty pointless, as at that point we're including wiki data that changes violently and uncontrollably with urls and such.

Additional context
We just want less builds

commented

parallel consideration:
given that we're making a mechanism to not build, we need a mechanism to bypass this check to force local builds.
so generally you'd want an environment variable, so we'd need to add documentation to the README to specify how to bypass the build hash checking