:bug: Inconsistent kitgun types
AyAyEm opened this issue · comments
Is your enhancement request related to a problem? Please describe.
The value of fortuna kitguns, type key, are Kitgun Component and deimos kitguns, type key, are Pistol.
Describe the upgrade you'd like
Set the type key of all kitguns to Pistol as it makes more sense in my head.
Additional context
[
{
"name":"Catchmoon",
"type":"Kitgun Component"
},
{
"name":"Gaze",
"type":"Kitgun Component"
},
{
"name":"Rattleguts",
"type":"Kitgun Component"
},
{
"name":"Tombfinger",
"type":"Kitgun Component"
},
{
"name":"Sporelacer",
"type":"Pistol"
},
{
"name":"Vermisplicer",
"type":"Pistol"
}
]
the deimos ones should be kitgun components, because kitguns are (by definition) modular, and both pistol and not. not sure where the json you're showing is from... but that's probably been in place for a while and isn't related to #312 unless DE changed their data.
Well the data is from the master branch and i've checked now the api: https://api.warframestat.us/items/Sporelacer?only=type
I think it's related to #312 because it changes their types i created this issue just because i was checking it.
So either create another pr to fix it and also adjust the current pr or just do it all in one which i think is the best.
It changed types due to a really old catch-all from changing /Shortguns to 'Pistol' instead of being 'Misc'.
If it's an issue on the pr, comment on the pr. if there's a type that you want changed, you can either put an issue for that type, or something else, i'm just confused why the initial problem (which is already in master) is being correlated to 312... which hasn't been built and deployed as of yet
Because their type changes and fixes this issue having all of the kitguns with a single type, as i tried to describe in my first comment in 312, just to be clear i've built it and checked typescript typings and later i'll make a more deep comparison.
🎉 This issue has been resolved in version 1.1252.66 🎉
The release is available on:
Your semantic-release bot 📦🚀