Great repo & found that some files are missing
m-albert opened this issue · comments
Hi @VolkerH, I was googling regarding the latest approaches on making napari available remotely and discovered this repo. It's super cool and I really like the detailed README. Thanks a lot!
Next to thanking I wanted to report a small issue I encountered. After following the instructions, everything worked well until I opened the 'noVNC' browser tab, which remained in a blank state of "loading". In the jupyter log I saw that some 404 errors where occurring, and it turned out that when comparing the jupyter_desktop subfolders between this repo and https://github.com/jupyterhub/jupyter-server-proxy, some differences showed up:
Only in jupyter-desktop-server/jupyter_desktop/share/web/noVNC-1.2.0/po: noVNC.pot
Only in jupyter-desktop-server/jupyter_desktop/share/web/noVNC-1.2.0/vendor/browser-es-module-loader: dist
Only in jupyter-desktop-server/jupyter_desktop/share/web/noVNC-1.2.0/vendor/pako: lib
After adding these to your repo, the blank novnc tab showed the desktop. So most likely the files just got lost when uploading the files.
Other than this everything worked as described in the readme 👌 Apart from docker not finding my GPU, but that's a different issue 😅.
Hi @m-albert
Nice to hear from you and thanks for the feedback :)
I wonder whether the missing files were caused by the .gitignore file.
Can I talk you into submitting a PR with the missing bits?
Note that some stuff is probably outdated and would require an update, e.g. a more recent base docker file than jupyter/base-notebook:python-3.9.10
Nice to hear from you, too :)
I wonder whether the missing files were caused by the .gitignore file.
Indeed that seems to have been the problem.
Can I talk you into submitting a PR with the missing bits?
Done, including modified .gitignore.
Note that some stuff is probably outdated and would require an update, e.g. a more recent base docker file than jupyter/base-notebook:python-3.9.10
I'll be playing around with it a bit and eventually propose an update :)
Thanks a lot! Looking forward to what you come up with. I changes jobs recently and don't really have the bandwidth to experiment with this. Closing issue via #3
Thanks! All the best for your new job