Strange behavior of class QuoteRequestBuilder
t13ka opened this issue · comments
I always thought that the builder should build something but on the contrary, we have different actions here which are not really correlated with the name. In my opinion, the builder should return some built object/s. This class serves as the storage or proxy or service or manager. It is quite hard to understand the idea
I suggest try this out for future refactoring: https://refactoring.guru/design-patterns/builder/csharp/example
Task https://virtocommerce.atlassian.net/browse/VP-3569 has been created
I agree on this, looking at the interface methods. probably Manager is better.
But I doubt we could change it, as it would be breaking change.
@tatarincev What do you think, could we change this interface name?
Task https://virtocommerce.atlassian.net/browse/VP-3713 has been created