Giters

ViaVersion / ViaFabricPlus

Fabric mod to connect to EVERY Minecraft server version (Release, Beta, Alpha, Classic, Snapshots, Bedrock) with QoL fixes to the gameplay

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mod incompatibility (Instantly disconnected from server)

Hlebuw3k opened this issue · comments

commented

General Information

ViaVersion dump url (v3.1.0): https://dump.viaversion.com/d209b75d284ad1a6b78053b26af3a9b26d4969643a82d850b2b1a99d4e40c8bc

ViaVersion dump url (snapshot version): https://dump.viaversion.com/328bd513bc6b06cca6393b04e1bc9846f73787f9283949ff3a41533ae283a128

Bug Description

Joining a 1.2.5 vanilla server will instantly disconnect me if either of the following mods are enabled:

Game version 1.20.4, Fabric Loader 0.15.7, tested with ViaFabricPlus v3.1.0 and a snapshot version from the actions page.
Tested with no other mods installed other than ViaFabricPlus and either one of the culprits (and Carpet Mod in the case of TIS Addition)
I have also joined the same server with over 100 other mods enabled, only when enabling either of those 2 causes me to get disconnected. I can share the mod list if requested.

Steps to Reproduce

  1. Install Minecraft 1.20.4, with Fabric Loader 0.15.7, and ViaFabricPlus 3.1.0
  2. Install Carpet TIS Addition https://modrinth.com/mod/carpet-tis-addition (with Carpet Mod as a dependancy, note that Carpet Mod does not cause this issue by itself https://modrinth.com/mod/carpet)
  3. OR install Vivecraft instead https://modrinth.com/mod/vivecraft
  4. Launch the game, select the correct versions 1.2.4-1.2.5 in the Via menu, then join a 1.2.5 server (I tested it with a local server with default settings, downloaded from https://minecraft.wiki/w/Java_Edition_1.2.5)
  5. You will be disconnected almost instantly, with the error message "Disconnected" shown as "lost connection: disconnect.genericReason" in the server console.

Expected Behavior

You should not be disconnected and should be able to enjoy happily playing Minecraft with those mods.

commented

ViaProxy can be used to bypass this issue: https://github.com/ViaVersion/ViaProxy but skins do not seem to work, and you can't select the same version as the server in the ViaFabricPlus menu if you are using it. And launching the non Java 8 version gives me an error "Java Virtual Machine Launcher: A Java Exception has occurred." right away and refuses to work.

commented

Hi, thanks for reporting this issue!
You don't need to share your mod list since it's already included in the ViaVersion dump.

Skins in ViaProxy are broken because you didn't enabled legacy skin loading in the advanced tab, I don't really understand what you mean with the "select same version as the server" part in ViaFabricPlus and the Java 8 version issue is most likely something with your Java installation (if not, you can create an issue on the ViaProxy github page).

To come back to your issue:
Fabric mods are known for breaking ViaFabricPlus/ViaVersion since they are sending modded networking data which is not translated properly by ViaVersion, you can try https://github.com/ViaVersionAddons/ViaVanillaPlus to see if that fixes your issue (It's a mod fixing other mod's networking to work with ViaVersion again), otherwise I would be interested if this issue only appears on <= 1.2.5 servers or if you can also test newer server versions like 1.8, 1.12 or 1.16.5? Sounds like a strange issue to me.