Vestride / Shuffle

Categorize, sort, and filter a responsive grid of items

Home Page:https://vestride.github.io/Shuffle/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

compound filter with search does not work

alombia opened this issue · comments

Ive been using the compound filter demo from your demo pages and it all works. However, when I try to add a search filter to it also, it does not work. It shows "Uncaught TypeError: Cannot read property 'textContent' of null". The code that causes the problem appears to be : var titleElement = element.querySelector('.picture-item__title');

Shuffle version
v

Describe the bug
A clear and concise description of what the bug is.

Reproduction link
A minimal JSBin, JSFiddle, Codepen, or a GitHub repository that can reproduce the bug. You can use this "Shuffle with Images" template on CodePen to get started: http://codepen.io/pen?template=qrjOpX

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hello :) I need help, please. i have similar problem. Everything works as expected except search. This codepen is fork from compound demo with search code added on line 215. Please help :) Thank you very much https://codepen.io/fogseller/pen/JjWrgqe

@alombia Hey, hello :) did you ever solved this problem?

@oohohoo you added the search methods, but then never called addSearchFilter anywhere. Adding that works.

@Vestride Hey mate, thank you 😀 but can you please tell me how to do it, what to put where? i'm just a beginner student :( thank you very much

Screen Shot 2021-05-29 at 10 43 47 AM

Line 60

YEAH! thats it it woooooorks thank you very very much! it works GREAT! yeah! 👯

last one, i promise :) how to search only already filtered items. for example if i filter 1 = megaboard and filter 2 = zagreb, and after that search for example "Bigboard". search result shows Billboard and overrides filter 1 and 2. is there any simple way that they works together. thank you mate :)