fix: flutter_gen breaks current template

Question

fix: flutter_gen breaks current template

NonymousMorlock opened this issue 3 months ago · comments

Description
After updating to very_good cli v0.20, and running create, it outputs a flutter project that depends on flutter_gen: any, so that when you run pub get, the l10n.dart errors out.

Target of URI doesn't exist: 'package:flutter_gen/gen_l10n/app_localizations.dart'.

Steps To Reproduce

Update your very_good_cli to v0.20
Create new flutter project
Open project in IDE
Run pub get
See error

Expected Behavior
Should compile successfully after running pub get

Additional Context
The template for the previous version of very_good_cli doesn't explicitly add flutter_gen to pubspec.yaml

haenah · Answer 1 · Wed Mar 06 2024 08:18:37 GMT+0800 (China Standard Time)

Same here ✋

haenah · Answer 2 · Wed Mar 06 2024 15:34:24 GMT+0800 (China Standard Time)

I fixed that with removing flutter_gen package dependency from pubspec.yaml.
I think since flutter_gen is already in pub.dev(link), and dart resolves flutter_gen with that package, so the generated code in .dart-tool is not used.

NonymousMorlock · Answer 3 · Wed Mar 06 2024 17:41:04 GMT+0800 (China Standard Time)

I fixed that with removing flutter_gen package dependency from pubspec.yaml. I think since flutter_gen is already in pub.dev(link), and dart resolves flutter_gen with that package, so the generated code in .dart-tool is not used.

Yeah, hopefully they fix it so we don't have to manually do that every project

Alejandro Santiago · Answer 4 · Wed Mar 06 2024 19:00:50 GMT+0800 (China Standard Time)

Somewhat duplicate of #973. I haven't been able to reproduce this myself, and the template itself doesn't seem to have flutter_gen: any explicitly defined in its pubspec.yaml.

@wolfenrain can you try to reproduce?

NonymousMorlock · Answer 5 · Wed Mar 06 2024 20:18:50 GMT+0800 (China Standard Time)

Then it could be from another source, maybe flutter create, as one of the comments in the issue you referenced suggests. and from what I see in that issue, this problem has been since before 0.20, but I've personally never encountered it since I started using very_good_cli and it's been a couple years, this is my first time encountering this. so it could be a random occurrence. I tried to create a new project tho and the same happened.

Jochum van der Ploeg · Answer 6 · Wed Mar 06 2024 22:55:12 GMT+0800 (China Standard Time)

Somewhat duplicate of #973. I haven't been able to reproduce this myself, and the template itself doesn't seem to have flutter_gen: any explicitly defined in its pubspec.yaml.

@wolfenrain can you try to reproduce?

I haven't been able to reproduce this here locally either. @NonymousMorlock can you maybe provide the output of flutter doctor. Just to ensure that we can reproduce it in a similar environment as you have.

NonymousMorlock · Answer 7 · Thu Mar 07 2024 02:34:29 GMT+0800 (China Standard Time)

I haven't been able to reproduce this here locally either. @NonymousMorlock can you maybe provide the output of flutter doctor. Just to ensure that we can reproduce it in a similar environment as you have.

[✓] Flutter (Channel stable, 3.19.0, on Fedora Linux 39 (Workstation Edition)
    6.7.7-200.fc39.x86_64, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.87.0)
[✓] Connected device (2 available)
[✓] Network resources

• No issues found!

Craig Labenz · Answer 8 · Sun Mar 10 2024 09:59:56 GMT+0800 (China Standard Time)

@wolfenrain I just encountered this today - happy to reproduce it together later this week if you'd like.

NonymousMorlock · Answer 9 · Tue Mar 12 2024 18:44:01 GMT+0800 (China Standard Time)

@craiglabenz NOOOOOOOOOOO WAYYYYYYYYYYY...I'm freaking out right now. Big fan, no no, Biggest FANNN, no way you're in my issue 😭😭😭😭😭😭

haenah · Answer 10 · Fri Mar 15 2024 08:35:14 GMT+0800 (China Standard Time)

Hi, I think I've found the reason.
After I execute dart fix, the following fix is made:

pubspec.yaml
  MISSING_DEPENDENCY • 1 fix

This is triggered by importing package:flutter_gen without declaring it inside pubspec.yaml. So dart fixer automatically add the flutter_gen: any line inside it.
If very good cli executes dart fix automatically after setup, this could be the reason.

Gyague Sonam · Answer 11 · Wed Apr 10 2024 03:56:35 GMT+0800 (China Standard Time)

As of current date and time this issue still persist. Today I updated all my IDE and tools to make a new flutter app. I got the same issue.

Strangely, If i create a project using the very_good cli in old directory, this issue didn't appear. I tried making new folder in documents and created a new project using very_good. Then there seem to be issue.

Note: this could be false positive or something to do with directory permission. But i fix it by removing flutter_gen: any in pubspec.yaml

Oeng Mengthong · Answer 12 · Fri Apr 12 2024 14:12:19 GMT+0800 (China Standard Time)

As of current date and time this issue still persist. Today I updated all my IDE and tools to make a new flutter app. I got the same issue.

Strangely, If i create a project using the very_good cli in old directory, this issue didn't appear. I tried making new folder in documents and created a new project using very_good. Then there seem to be issue.

Note: this could be false positive or something to do with directory permission. But i fix it by removing flutter_gen: any in pubspec.yaml

I solved by remove flutter_gen too. because flutter_gen already building with flutter