Weather Forecast

Question

Weather Forecast

luminousbeam opened this issue 3 years ago · comments

JocelynJeriah commented 3 years ago

I thought the assistant could also pull weather info from an API.

Veer Shah · Answer 1 · Sun Oct 03 2021 17:38:38 GMT+0800 (China Standard Time)

Sure, thanks for the Idea, would you like to work on this ?
@luminousbeam

JocelynJeriah · Answer 2 · Mon Oct 04 2021 01:37:39 GMT+0800 (China Standard Time)

Hi @Veershah26 I would! However, I'd like some help in making sure that I'm setting up the repo correctly. I'd also like to add the requirements.txt and perhaps update the README with setup instruction

CS-Aditya-Rawat · Answer 3 · Mon Oct 04 2021 15:36:04 GMT+0800 (China Standard Time)

Hey @Veershah26 If anyone is not working on this feature. I can add it.

Veer Shah · Answer 4 · Mon Oct 04 2021 21:54:31 GMT+0800 (China Standard Time)

@luminousbeam . Sorry for the late reply, But i have assigned this issue to you now. Have a great time.

Regards
Veer Shah

Veer Shah · Answer 5 · Tue Oct 05 2021 01:49:45 GMT+0800 (China Standard Time)

@luminousbeam so that now the pr is merged, but before i close this issue, you know that the code for the weather forecast is pretty big, so would you rather have, the assistant, execute the file each time or call a class from the file (IMO, implementing this in a class might be a tad bit complicated)

JocelynJeriah · Answer 6 · Tue Oct 05 2021 02:46:04 GMT+0800 (China Standard Time)

Let’s take the fastest and most efficient route. To be honest, I’m not sure which way would work best with the Virtual Assistant, so I would defer to your better judgment. I’m also currently away on a trip this week, left today, and will not have access to a computer until Saturday.

…

Sent from my iPhone

On Oct 4, 2021, at 1:49 PM, Veer Shah ***@***.***> wrote: @luminousbeam so that now the pr is merged, but before i close this issue, you know that the code for the weather forecast is pretty big, so would you rather have, the assistant, execute the file each time or call a class from the file (IMO, implementing this in a class might be a tad bit complicated) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

JocelynJeriah · Answer 7 · Sun Oct 10 2021 05:43:05 GMT+0800 (China Standard Time)

@Veershah26 do you think that within the weather.py file we can just break up the items into methods? like def wind() and def clouds(), def temp(), etc

Veer Shah · Answer 8 · Sun Oct 10 2021 22:40:01 GMT+0800 (China Standard Time)

@Veershah26 do you think that within the weather.py file we can just break up the items into methods? like def wind() and def clouds(), def temp(), etc

Sure, than all it would take is call the def method_name() into main file.

JocelynJeriah · Answer 9 · Mon Oct 11 2021 00:13:23 GMT+0800 (China Standard Time)

@Veershah26 I worked on this both yesterday and today. I did a lot of testing and we'd be able to pull in the weather module and call methods easily within main.py. We can import modules.weather as weather and then have the assistant speak(weather.temp()) for example :) Here's my PR #27

JocelynJeriah · Answer 10 · Mon Oct 11 2021 02:26:28 GMT+0800 (China Standard Time)

Thanks for the quick review and merge! I will close this issue, we can open a new one if you want me to add or change functionality.