More `setState` warnings

Question

More `setState` warnings

jhen0409 opened this issue 8 years ago · comments

Jhen-Jie Hong commented 8 years ago

It seems this line will unmount JellySideMenuSvg, so setState will not work in JellySideMenuSvg.

Rizwan Jamal ⚡️ commented 8 years ago

Thanks :)

VansonLeung · Answer 1 · Sun Jul 10 2016 22:45:45 GMT+0800 (China Standard Time)

Thanks, fixed

Jhen-Jie Hong · Answer 2 · Mon Jul 11 2016 17:05:55 GMT+0800 (China Standard Time)

@VansonLeung I don't think it's fixed, isMounted is killed in new react version, and it's not the right place. I think we should remove all listeners in componentWillUnmount for JellySideMenuSvg.

VansonLeung · Answer 3 · Mon Jul 11 2016 23:36:15 GMT+0800 (China Standard Time)

Fixed thanks

Rizwan Jamal ⚡️ · Answer 4 · Fri Aug 19 2016 15:24:34 GMT+0800 (China Standard Time)

I am recently used this module, but got warnings on every single click on Close Side Menu & when I click on open Jelly Menu it breaks the code & the animation stop working ...

VansonLeung · Answer 5 · Fri Aug 19 2016 22:03:46 GMT+0800 (China Standard Time)

Thanks, will fix by tomorrow!