Vanilla-OS / ABRoot

ABRoot is a utility that provides full immutability and atomicity to a Linux system, by transacting between two root filesystems. Updates are performed using OCI images, to ensure that the system is always in a consistent state.

Home Page:http://abroot.vanillaos.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Lockfile doesn't get removed after an operation

matbme opened this issue · comments

When running an upgrade or apply operation, the lockfile remains in /tmp even after a reboot, which prevents running any other operation until it is manually deleted.

commented

I can't reproduce this.
After an upgrade, the lock file is successfully removed.
The issue I see is that it is created when trying to auto-upgrade on boot.

Weird. I can reproduce this in both a fresh install and an older one after updating. I'll look deeper into this when I have the time.

commented

@matbme Are you checking right after the upgrade or after the reboot?

@matbme Are you checking right after the upgrade or after the reboot?

Both. It's there before and after the reboot.

commented

Yeah, so after rebooting it is actually cleared but then abroot is executed by vso so the lockfile is there again.

image
the lock disappear both when it fails or succeed so I think that transaction was still running so the lock file was being preserved, the only reason the lock file don't get deleted is in case abroot crashes or get killed, which I think is not the case.

Since I am not able to replicate, can anyone tell me if abroot is still running when that happen?

commented

@mirkobrombin
Abroot is not running when the lock file exists after upgrading.

Note that abroot is being started multiple times (3-4 times) by vso which might have something to do with this.

Maybe the sysd timer is not working as expected and then keep running it