ValveSoftware / halflife

Half-Life 1 engine based games

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[CS1.6] Crash m_PanelList.Count() < WARN_PANEL_NUMBER

Splatt581 opened this issue · comments

A crash occurs when trying to open Options in game client:

image

Tested on build:

Protocol version 48
Exe version 1.1.2.7/Stdio (cstrike)
Exe build: 01:03:30 Dec 1 2023 (9899)

OS Win10 x64

This error occurs if there are too many files in the cstrike_downloads folder:

image

I found this condition in vgui2 code:

  if ( *(_WORD *)(v11 + 26) >= 0x1000u ) //4096
    wassert(
      L"m_PanelList.Count() < WARN_PANEL_NUMBER",
      L"c:\\buildslave\\goldsrc_win32\\build\\GoldSrc\\vgui2\\src\\vgui.cpp",
      0x226u);

If I patch this code, no error occurs and the options open normally.

@mikela-valve is it possible to fix this? since in the steam_legacy branch the game client does not close when trying to open options.

Seems to be fixed in build 9909, but it takes a while to open it.

Yeah, this is fixed in build 9909.