Building in visual studio 2015

Question

Building in visual studio 2015

Tfelk opened this issue 8 years ago · comments

Is this possible? Im getting a few errors trying to build "libprotobuf" as described in the readme. Maybe its because im in VS2015.

Here are the errors:

1>C:\Program Files (x86)\VC\include\hash_map(17): error C2338: <hash_map> is deprecated and will be REMOVED. Please use <unordered_map>. You can define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning.
1>C:\Program Files (x86)\VC\include\hash_set(17): error C2338: <hash_set> is deprecated and will be REMOVED. Please use <unordered_set>. You can define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS to acknowledge that you have received this warning.

This pair of errors occurs 6 times, additionally:

1>..\src\google\protobuf\io\zero_copy_stream_impl_lite.cc(66): error C3861: 'min': identifier not found
1>..\src\google\protobuf\io\zero_copy_stream_impl_lite.cc(119): error C3861: 'min': identifier not found
1>..\src\google\protobuf\io\zero_copy_stream_impl_lite.cc(166): error C3861: 'max': identifier not found
1>..\src\google\protobuf\io\zero_copy_stream_impl_lite.cc(193): error C3861: 'min': identifier not found

TheName · Answer 1 · Mon Aug 15 2016 18:57:11 GMT+0800 (China Standard Time)

Hey, I'm not too sure what changed between VS2010 and VS2015 but these errors can easily be fixed.
For the hash_map error do as it says, define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS and the min max errors can be fixed by including algorithm in the mentioned file.
Note that I'm not sure if this is the correct solution or why algorithm wasn't included in the first place but for me this fixed all errors and I can build on VS2015.

Jacob · Answer 2 · Thu Aug 25 2016 11:07:51 GMT+0800 (China Standard Time)

You can write the code by yourself like this:
#define min(x,y) x>y?y:x
#define max(x,y) x>y?x:y

patrikohlsson · Answer 3 · Tue Sep 27 2016 03:01:01 GMT+0800 (China Standard Time)

That could cause precedence issues, if you're defining them yourself it should be:

#define min(x,y) ((x)>(y)?(y):(x)) 
#define max(x,y) ((x)>(y)?(x):(y))

Just including the algorithm header and defining _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS solves it too.

EDIT: Statement should also have surrounding parenthesis

Ben Jackson · Answer 4 · Tue Sep 27 2016 03:09:50 GMT+0800 (China Standard Time)

Actually the whole thing should be in parenthesis too.

On Mon, Sep 26, 2016 at 12:01 PM, patrikohlsson notifications@github.com
wrote:

That could cause precedence issues, if you're defining them yourself it
should be:

#define min(x,y) (x)>(y)?(y):(x)
#define max(x,y) (x)>(y)?(x):(y)

Just including the algorithm header and defining _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS
solves it too.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD0TZjnNx05RuaubP-B9lU6QX0l6vYxks5quBZugaJpZM4JCngK
.

patrikohlsson · Answer 5 · Tue Sep 27 2016 03:10:49 GMT+0800 (China Standard Time)

Yes, forgot about that!

Andrew Strange · Answer 6 · Wed Mar 22 2017 01:12:10 GMT+0800 (China Standard Time)

Might be foolish, but I'm having crashes after building related to heap corruption and access violation in the protobuf. I'm using vs2017 and applied they above workarounds to hash map and min/max. Is this likely some kind of configuration error on my part?

Jacob · Answer 7 · Thu Mar 23 2017 18:00:20 GMT+0800 (China Standard Time)

I am trying to write this in golang!

Deleted user · Answer 8 · Wed Dec 27 2017 22:14:45 GMT+0800 (China Standard Time)

@bjj Worked without extra parenthesis.

@lemming52 Works for me in VS2013 Community.

Muhammad Shaheer · Answer 9 · Tue Jul 10 2018 16:16:46 GMT+0800 (China Standard Time)

I am having these errors in VS2017. how can i fix them and where do i need to append_SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS ??