Outlier mask is still permuted when returned
luccareinehr opened this issue · comments
unstructured_outlier_mask is not reversely permuted when returned from SPQRUtil.quantize(). Consequently, when comparing the outlier mask and the quantised weights, the positions of the outliers do not correspond.
Is there any reason for this? From what I saw it doesn't affect the functionality of the program whatsoever, but caused me some headaches when studying and debugging the code
Never mind, just noticed the NOTE on https://github.com/Vahe1994/SpQR/blob/dffd0302741e5b8a0dea9713fcf38e1cc4f3ac8f/spqr_engine.py#L209C4-L209C4. It can get easily forgotten, still