CPU ran into 200%+ in VSCode 1.18.0

Question

CPU ran into 200%+ in VSCode 1.18.0

gonghao opened this issue 7 years ago · comments

Howtin commented 7 years ago

Click thumbs-up 👍 on this issue if you want it!
Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

VSCode Version: 1.18.0
VsCodeVim Version: 0.10.2
OS: macOS 10.13.2 Beta (17C67b)

What happened:

When I upgrade to VSCode 1.18.0 the CPU ran into extreme high, I found it caused by two Code Helper.app processes. Then I just disabled all extensions, everything is OK. It is clear that this issues is caused by extensions conflicts with VSCode, so I re-enabled each extension to figure out which one caused this situation. Finally I found it is VSCodeVim, I just re-enabled every other extensions everything is OK, but after re-enable VSCodeVim, the CPU went high.

So I don't know do you guys have the same issue?

What did you expect to happen:

Normal CPU usage.

How to reproduce it:

Install VSCode 1.18.0
Install VSCodeVim and enabled it

Francesc Arpí Roca · Answer 1 · Thu Nov 09 2017 15:12:40 GMT+0800 (China Standard Time)

On Windows 10, the same happens.

Ivan Voznyakovsky · Answer 2 · Thu Nov 09 2017 19:28:18 GMT+0800 (China Standard Time)

Same on High Sierra 10.13. Opening a file creates 2 CodeHelper processes with 100%+ CPU usage.

Jake Broughton · Answer 3 · Fri Nov 10 2017 00:07:09 GMT+0800 (China Standard Time)

Yep. Same on High Sierra, also on VSCode Insiders

Stephen St. Martin · Answer 4 · Fri Nov 10 2017 03:25:42 GMT+0800 (China Standard Time)

Same occurs on macOS 10.12.6

Colin Bell · Answer 5 · Fri Nov 10 2017 12:58:55 GMT+0800 (China Standard Time)

I've got the same problem on Ubuntu 17.10.

I disabled "Easy motion", I.E added "vim.easymotion": false, to the user settings file, restarted VS Code and opened a Ruby source file. Once the "indexing ruby source" finishes the CPU dropped away.

So it looks like an issue with "Easy Motion".

Ignore the above. It hasn't fixed it. The CPU stays down until you start moving the cursor around in the source file, once you do that the CPU rises again and stays up.

Last Attempt

I open the User settings and quit VS Code. Then start it up again, open my Ruby source file and start editing, everything is fine, CPU is low. Play around for a while, quit and restart. Now the problem starts again.

It seems that if VS Code has a source file active when it starts up then the problem occurs but if you start it up with the user settings as the active pane and then open a source file you are ok.

Can anybody else confirm this behaviour or am I going slightly crazy- its been a long day.

Stephen St. Martin · Answer 6 · Fri Nov 10 2017 22:28:31 GMT+0800 (China Standard Time)

@colbell confirmed, if I open it with any source file active even a blank one CPU usage spikes, if i open the user settings tab and relaunch CPU is low. I can consistently reproduce this, switching to a source code tab after launch, or having source code tabs open (regardless of tab order) at launch CPU still remains low, it seems this occurs only when a source code based tab has focus on launch.

Ivan Voznyakovsky · Answer 7 · Fri Nov 10 2017 22:41:10 GMT+0800 (China Standard Time)

I have my CPU going crazy whenever a file is focused or vscode is re-open with a prev file opened. once I have any file opened CPU usage spikes.

Adam Wiggall · Answer 8 · Sat Nov 11 2017 01:03:47 GMT+0800 (China Standard Time)

Same for me on Sierra 10.12.6, running VS code 1.18.0.

Dotan J. Nahum · Answer 9 · Sat Nov 11 2017 01:06:35 GMT+0800 (China Standard Time)

Have the same thing. Arrived at Vim extension by elimination of extensions. Profiled the extension and got this:

Which hints at my customising the status bar colors. Removed my config and everything is normal again!

Stephen St. Martin · Answer 10 · Sat Nov 11 2017 01:15:47 GMT+0800 (China Standard Time)

Disabling custom status bar colors corrected the problem for me also.

Howtin · Answer 11 · Sat Nov 11 2017 01:20:07 GMT+0800 (China Standard Time)

@jondot Great job! I just disabled the customize status bar colors, everything goes well!

Colin Bell · Answer 12 · Sat Nov 11 2017 06:21:19 GMT+0800 (China Standard Time)

Nice one @jondot disabling the colours fixed it for me too.

Ivan Voznyakovsky · Answer 13 · Sat Nov 11 2017 19:58:54 GMT+0800 (China Standard Time)

confirm that "vim.statusBarColorControl": false fixes the issue. great catch @jondot 👍
don't think it's a real fix but rather a workaround 😄

Chase Starr · Answer 14 · Sun Nov 12 2017 02:31:48 GMT+0800 (China Standard Time)

I can reproduce consistently on Version 1.18.

Just tested in Version 1.19.0-insider 11-11-17 on MacOS Sierra 10.12.5 and cannot reproduce CPU spike.

@MythicalFish can you still repro? I can't find a PR relevant to this issue landing in vscode from the past few days - which I find strange https://github.com/Microsoft/vscode/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aclosed%20closed%3A%3E2017-11-07

Zheng Xu · Answer 15 · Sun Nov 12 2017 18:38:21 GMT+0800 (China Standard Time)

same for me on macOS 10.11.6 and vscode 1.18.

newro · Answer 16 · Tue Nov 14 2017 09:45:04 GMT+0800 (China Standard Time)

I am experiencing a phenomenon that the CPU becomes higher after vscode 1.18 update in the Win10 environment.
The code helper process is using a high CPU, and disabling the vim plugin disables the symptom.

Scott Wade · Answer 17 · Mon Dec 04 2017 02:07:56 GMT+0800 (China Standard Time)

It was the vim extension causing the 100% CPU usage issue for me also. Removing any/all "neovim" related settings took care of the problem. Just changing some to a 'disabled' value or just commenting out did not work. I had to totally remove then entries.

Horace He · Answer 18 · Fri Mar 09 2018 04:37:30 GMT+0800 (China Standard Time)

Does anybody still get this issue on recent versions of VSCodeVim?

bas72 · Answer 19 · Tue Mar 27 2018 18:50:04 GMT+0800 (China Standard Time)

I still experienced this issue in 1.21.1 and for me it was fixed by commenting out the "vim.disableAnnoyingNeovimMessage" setting.

Jason Poon · Answer 20 · Wed Mar 28 2018 04:40:47 GMT+0800 (China Standard Time)

@stevebasford that setting is deprecated, it was removed awhile ago. Closing this issue as it seems resolved.

ChasKane · Answer 21 · Sat Jun 08 2019 07:43:23 GMT+0800 (China Standard Time)

I was brought here by the below link (about 2/3 of the way down the page, in the emulated-plugins section), thinking I couldn't use vim-airline with VSCodeVim. It seems this no longer affecting vim-airline, yes? Might be best to remove the disclaimer at the top of the emulated-plugins section

https://marketplace.visualstudio.com/items?itemName=vscodevim.vim#-emulated-plugins

xelaos · Answer 22 · Tue Jul 02 2019 16:13:38 GMT+0800 (China Standard Time)

From my experience it depends on the machine you are using. Maybe it was worse in 2017 regardless of your machine, but it is still an issue.

Andy Earnshaw · Answer 23 · Tue Mar 03 2020 06:27:16 GMT+0800 (China Standard Time)

I'd recommend sticking a 👍 on microsoft/vscode#43226 if you want to be able to enable statusbar colours without performance issues.

Nadav Zingerman · Answer 24 · Sun Feb 07 2021 17:26:21 GMT+0800 (China Standard Time)

Could this recent change solve this?
https://code.visualstudio.com/updates/v1_53#_status-bar-entry-background-color-api

Florian Bruhin · Answer 25 · Fri May 21 2021 00:48:24 GMT+0800 (China Standard Time)

@nzig that blog post says:

Currently only statusBarItem.errorBackground is supported to avoid the Status bar looking too colorful.

so it looks to me like that'd be of limited use...

FWIW I managed to find a solution to color the status bar item based on its text, using the Customize UI extension:

    "customizeUI.stylesheet": {
        "#vscodevim\\.vim\\.primary[aria-label=\"-- INSERT --\"]": "background-color: #98971a !important;",
        "#vscodevim\\.vim\\.primary[aria-label=\"-- VISUAL --\"]": "background-color: #b16286 !important;",
        "#vscodevim\\.vim\\.primary[aria-label^=\":\"]": "background-color: #7c6f64 !important;",
    },

result:

Edgar · Answer 26 · Sun May 29 2022 10:25:25 GMT+0800 (China Standard Time)

FWIW I managed to find a solution to color the status bar item based on its text, using the Customize UI extension:

For some reason this does not work for me. How do you find those values ("#vscodevim\..."). Maybe those are different now.

Florian Bruhin · Answer 27 · Sun May 29 2022 19:14:08 GMT+0800 (China Standard Time)

FWIW I managed to find a solution to color the status bar item based on its text, using the Customize UI extension:

For some reason this does not work for me. How do you find those values ("#vscodevim..."). Maybe those are different now.

They are indeed! It's #vscodevim\\.vim\\.primary now, adjusted above.

I found them by opening the developer tools (Ctrl-Shift-P, "Developer: Toggle Developer tools") and then using the picker at the top left of the "Elements" tab to inspect the element.

Robert Warner · Answer 28 · Wed Aug 09 2023 04:09:58 GMT+0800 (China Standard Time)

FYI, Customize UI no longer works so that option is off the table :(

I'd love to get something along these lines, as I'm often not noticing which mode I'm in, even with different cursors for insert vs normal.

Florian Bruhin · Answer 29 · Wed Aug 09 2023 04:16:53 GMT+0800 (China Standard Time)

FYI, Customize UI no longer works so that option is off the table :(

I switched to be5invis/vscode-custom-css which still works (though since the CSS is placed in a normal file with it, use \ instead of \\ and " instead of \" above).

Jonatan Mark Bakucz · Answer 30 · Tue Jul 16 2024 23:22:44 GMT+0800 (China Standard Time)

FYI, Customize UI no longer works so that option is off the table :(

I switched to be5invis/vscode-custom-css which still works (though since the CSS is placed in a normal file with it, use \ instead of \\ and " instead of \" above).

I seriously love your solution, I modified it a bit to color the whole status bar to make it more visible of a change.

    #workbench\.parts\.statusbar:has([aria-label="-- NORMAL --"]) {
        background-color: #27981a !important;
    }

    #workbench\.parts\.statusbar:has([aria-label="-- INSERT --"]) {
        background-color: #de080f !important;
    }

    #workbench\.parts\.statusbar:has([aria-label="-- VISUAL --"]) {
        background-color: #8362b1 !important;
    }

    #workbench\.parts\.statusbar:has([aria-label="-- VISUAL LINE --"]) {
        background-color: #62b1b1 !important;
    }

Raúl Peñate · Answer 31 · Thu Sep 12 2024 20:27:47 GMT+0800 (China Standard Time)

An easy alternative solution is to install and give permissions to Apc Customize UI++ and add the following to settings.json:

{
  "apc.stylesheet": {
    /* Default footer style */
    ".part.statusbar.status-border-top": "background-color: rgb(143, 188, 187); color: rgb(67, 76, 94);",
    /* Apply styles based on aria-label in the footer */
    ".part.statusbar.status-border-top [aria-label='-- NORMAL --']": "background-color: #8FBCBB; color: #434C5E;",
    ".part.statusbar.status-border-top [aria-label='-- INSERT --']": "background-color: #BF616A; color: #434C5E;",
    ".part.statusbar.status-border-top [aria-label='-- VISUAL --']": "background-color: #B48EAD; color: #434C5E;",
    ".part.statusbar.status-border-top [aria-label='-- VISUAL LINE --']": "background-color: #B48EAD; color: #434C5E;"
  }
}

Malik Danial Azhar · Answer 32 · Fri Sep 20 2024 00:55:29 GMT+0800 (China Standard Time)

An easy alternative solution is to install and give permissions to Apc Customize UI++ and add the following to settings.json:

{
  "apc.stylesheet": {
    /* Default footer style */
    ".part.statusbar.status-border-top": "background-color: rgb(143, 188, 187); color: rgb(67, 76, 94);",
    /* Apply styles based on aria-label in the footer */
    ".part.statusbar.status-border-top [aria-label='-- NORMAL --']": "background-color: #8FBCBB; color: #434C5E;",
    ".part.statusbar.status-border-top [aria-label='-- INSERT --']": "background-color: #BF616A; color: #434C5E;",
    ".part.statusbar.status-border-top [aria-label='-- VISUAL --']": "background-color: #B48EAD; color: #434C5E;",
    ".part.statusbar.status-border-top [aria-label='-- VISUAL LINE --']": "background-color: #B48EAD; color: #434C5E;"
  }
}

Really helpful answer, because I belive if you use the "vim.statusBarColorControl" option then you cannot use "extensions.experimental.affinity" correctly because it keeps updating the settings.json.

I added a few things to your settings hope it helps, feel more complete now.

  "apc.stylesheet": {
    /* Apply styles based on aria-label in the footer */
    "#vscodevim\\.vim\\.primary": "padding: 0 4px;",
    "#vscodevim\\.vim\\.primary[aria-label='Already at oldest change']": "background-color: #475569; color: #d1d5db;",
    "#vscodevim\\.vim\\.primary[aria-label^='-- NORMAL']": "background-color: #8FBCBB; color: #434C5E;",
    "#vscodevim\\.vim\\.primary[aria-label='-- INSERT --']": "background-color: #BF616A; color: #e5e7eb;",
    "#vscodevim\\.vim\\.primary[aria-label='-- VISUAL --'], #vscodevim\\.vim\\.primary[aria-label='-- VISUAL LINE --']": "background-color: #B48EAD; color: #e5e7eb;",
    "#vscodevim\\.vim\\.primary[aria-label='-- VISUAL BLOCK --']": "background-color: #A3BE8C; color: #434C5E;",
    "#vscodevim\\.vim\\.primary[aria-label='-- REPLACE --']": "background-color: #D08770; color: #434C5E;",
    "#vscodevim\\.vim\\.primary[aria-label='-- EASYMOTION INPUT --'], #vscodevim\\.vim\\.primary[aria-label='-- SURROUND INPUT --']": "background-color: #007ACC; color: #e5e7eb;",
    "#vscodevim\\.vim\\.primary[aria-label^=':'], #vscodevim\\.vim\\.showcmd": "color: #fafafa;"
  }