Unleash / unleash

Open-source feature management solution built for developers.

Home Page:https://getunleash.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Strategy parameter list format specification

evenbrenden opened this issue · comments

Describe the feature request

The client specification tests suggests that strategy parameter lists use spacing in between values. In practice, clients receive values without spacing:

"strategies": [
      {
        "name": "userWithId",
        "parameters": {
          "userIds": "1,2,3"
        },
        "constraints": []
      }
    ],

Also, if space is added when entering the values, leading whitespace is removed, but trailing is not:

screenshot

    "strategies": [
      {
        "name": "userWithId",
        "parameters": {
          "userIds": "a,b,c    ,d"
        },
        "constraints": []
      }
    ],

I cannot find a specification for this parameter list string - apologies if I missed it.

This was tested against Unleash 3.17.4 - old, I know, but I cannot see any similar issues merged since.

Background

A specification would tighten parsing in Unleash clients.

Solution suggestions

Specify the format for the parameter list string.

Hi, Unleash v3 is EOL more than 1 year ago.

userWithId strategy is a deprecated strategy. In newer versions of Unleash you will use constraints instead. Constraints model values as proper arrays in the format and this is not a problem anymore.