UV Version 4.x not supporting static images (non-IIIF images)
kirschbombe opened this issue · comments
UV version:
universalviewer@v4.0.0
universalviewer@v4.0.21
I'm submitting a:
- bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below
- feature request => please use the user stories repo
- support request => Please do not submit support requests here, use stackoverflow
Current behavior:
When loading a manifest with a static (non-IIIF) image on a canvas, UV v4.x does not display the static image and the loading icon continues to spin. The browser console log gives the error: Assertion failed: [Viewport._setContentBounds] bounds.height must be greater than 0 8863.c56e62097ef300b4ee08.js:2:183437
Expected behavior:
I would expect the static image to load as it does in UV v3.1.4:
https://uv-v3.netlify.app/#?c=&m=&s=&cv=&manifest=https%3A%2F%2Ftest.iiif.library.ucla.edu%2Fark%253A%252F21198%252Fz1hf3f9k%2Fmanifest
Steps to reproduce:
Here is an example manifest, which works in v3.1.4 (above): An example manifest: https://test.iiif.library.ucla.edu/ark%3A%2F21198%2Fz1hf3f9k/manifest
However, it does not work as expected in v4.0.0 (the UV demo) or v4.0.21
Related code:
// insert any relevant code here
Other information:
@kirschbombe, this seems to be working for me in universalviewer.dev (the latest dev branch): https://www.universalviewer.dev/#?xywh=-3260%2C-285%2C9357%2C4245&iiifManifestId=https%3A%2F%2Ftest.iiif.library.ucla.edu%2Fark%253A%252F21198%252Fz1hf3f9k%2Fmanifest
Am I missing something?
It does appear to be broken in universalviewer.io (the 4.0.0 release): https://uv-v4.netlify.app/#?manifest=https://www.universalviewer.dev/#?xywh=-3260%2C-285%2C9357%2C4245&iiifManifestId=https%3A%2F%2Ftest.iiif.library.ucla.edu%2Fark%253A%252F21198%252Fz1hf3f9k%2Fmanifest&c=&m=&cv=
Is it possible this was already fixed subsequent to release 4.0.21?
Yes, it looks to be fixed in dev - I didn't test it there, only in the most recent versions I knew about (4.0.0 and 4.0.21 which is what the UCLA Library is currently using). It looks like the most recent release is 4.0.25, so I'll test there - is there a demo up for that version? I'll check code sandbox.
It's not working in code sandbox, but I'm not sure which version of 4 that is. I would like to test the most recent release if there is a demo up somewhere before I ask our devs to update to that version.
@kirschbombe, we talked on today's Community Call about establishing a new netlify instance for testing the latest release, so it's easier to compare against the dev branch. I think @edsilv plans to work on that next week, and then we can hopefully do further comparison.
I'm not sure when the next release will be scheduled -- we're currently working on formalizing processes and procedures to make the release process more predictable. If this is an urgent need, let me know and I'll bring it up on the next Steering Group call.
Thank you, @demiankatz! I wouldn't say "urgent" since I think that rarely applies in library context, but is time sensitive for us since we have some grant-funded collections that we need to publish soon. If the group has time to discuss in the next meeting, that would be great. But if @edsilv is able to get a new netlify instance up, that would be wonderful. Also because I'm going to suggest that the IIIF Cookbook start using the current UV instance for demoing (it's still using v3). So, two birds... :)
@edsilv @demiankatz Please make sure any work agreed on is added as a task to the community board :)
Update: I had one of our graduate students spin up an instance of the most recent release (4.0.25) to test the static image manifests and the issue appears to be fixed here: https://uclalibrary.github.io/uv4025_demo/. Shall I go ahead and close this ticket?
Great news, @kirschbombe -- I'll go ahead and close this now.