Sorting tokens in fixture does not work

Question

sz-piotr opened this issue 4 years ago · comments

Because ethers returns a string from this method call, .address always results in undefined, thus the order of tokens is never changed.

Moody Salem · Answer 1 · Tue Sep 15 2020 22:34:18 GMT+0800 (China Standard Time)

Good catch! I guess token0 and token1 must always be the same for the fixture, so we never had failing tests out of it.

Devendra Yadav · Answer 2 · Thu Oct 29 2020 04:41:13 GMT+0800 (China Standard Time)

Good catch! I guess token0 and token1 must always be the same for the fixture, so we never had failing tests out of it.

Sir, how can token0 and token1 be same for pairFixture ?

Moody Salem · Answer 3 · Thu Oct 29 2020 05:34:33 GMT+0800 (China Standard Time)

I mean same addresses across test runs (but token0 != token1), since we use the same mnemonic for every test run

Devendra Yadav · Answer 4 · Thu Oct 29 2020 16:37:53 GMT+0800 (China Standard Time)

Okay so it'll fail for different pair address and pass for same pair address right?

Deleted user · Answer 5 · Mon Jan 01 2024 03:34:18 GMT+0800 (China Standard Time)

I think the best fix would be to lowercase the addresses of the token and just compare like how it is done from the factory contract as well.