Unidata / netcdf-cxx4

Official GitHub repository for netCDF-C++ libraries and utilities.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Erroneous condition always evaluating true

opened this issue · comments

In https://github.com/Unidata/netcdf-cxx4/blob/master/cxx4/ncGroup.cpp
lines 1318 and 1356.
Condition location != ParentsAndCurrent || location != All is always true, i believe.

It also looks like Location::Parents and Location::Children are possibly not handled correctly either.

Are Location::Parents/Children supposed to be synonyms for the Location::*AndChildren enums in this context? That is, should group.getCoordVars(NcGroup::Parents) always also search the current group?