Giters

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other Game Maker: Studio games!)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Throw a warning for broken room order entries

nkrapivin opened this issue · comments

commented

Which component should be improved?

Lib

Describe your feature suggestion in more detail

It's possible to specify a duplicate room in the RoomOrderNodes in a YYP file, leading to some very cursed results within the game and ModTool.

For example:

  "RoomOrderNodes": [
    {"roomId":{"name":"Room1","path":"rooms/Room1/Room1.yy",},},
    {"roomId":{"name":"Room2","path":"rooms/Room2/Room2.yy",},},
    {"roomId":{"name":"Room2","path":"rooms/Room2/Room2.yy",},},
  ],

will actually load, but the room will be duplicated in the asset list:

image

I don't know if it's a bug or not, technically there is only one room asset, but multiple room order nodes for it, this is highly cursed and is a GameMaker bug but it's technically allowed as the game builds and runs, so maybe ModTool should catch such cases and warn the user?