Redundant i_expected_max parameter when calibrating ina219
dernasherbrezon opened this issue · comments
dernasherbrezon commented
The issue
I noticed that ina219 calibration function has i_expected_max parameter.
esp_err_t ina219_calibrate(ina219_t *dev, float i_expected_max, float r_shunt)
{
...
}
However this parameter is only printed into the log. Is it a bug in the calibration function? Or left over from the old logic? It has quite complicated configuration in the example code through Kconfig.projbuild, which looks redundant.
Which SDK are you using?
esp-idf
Which version of SDK are you using?
master
Which build target have you used?
- esp32
- esp32s2
- esp32s3
- esp32c2
- esp8266
- other
Component causing the issue
ina219
Anything in the logs that might be useful for us?
No response
Additional information or context
No response
Confirmation
- This report is not a question nor a request for drivers.