Not possible to build shared on windows
mjvankampen opened this issue · comments
There are no __declspec(dllexport)
or __declspec(dllimport)
statements.
We haven't had a demand for that yet given the model of how we've used Protolib to date. If there is demand for that, it could be accommodated. Although, we haven't taken a lot of care in Protolib to clearly delineate "clean" public API interfaces to the classes ... I've made a little effort to do that in some cases, but have not been completely consistent in doing so. For example, there are some inconsistencies in method naming conventions among the Protolib classes I would clean up among other things
I'll try https://cmake.org/cmake/help/latest/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html#prop_tgt:WINDOWS_EXPORT_ALL_SYMBOLS to just export all. Maybe that's sufficient.
As discussed in USNavalResearchLaboratory/norm#15 protolib should be static.